Add DeviceName to Welcome Screen #5173
Conversation
DROID-93 Add Device name to Create account flow
We want to show the device name in more places so that users see it as early as possible. Therefore we should also present the device name when a user creates an account through the app. This is done by showing the device name underneath the new account number and also includes an info button that opens a dialog explaining the device concept further. Note: The Confluence and Zeplin links references other work as well Confluence: https://mullvad.atlassian.net/l/cp/1tRhWft7 Zeplin: https://zpl.io/W49PNqx |
Rawa
force-pushed
the
add-device-name-to-create-account-flow-droid-93
branch
2 times, most recently
from
814ec3f
to
ef95782
Compare
Rawa
force-pushed
the
add-device-name-to-create-account-flow-droid-93
branch
from
ef95782
to
332faa4
Compare
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/WelcomeScreen.kt line 204 at r2 (raw file):
) } if (showDeviceNameDialog) {
So this is more future-proofing, but we will add other types of dialoges in this view in the future connected to billing.
How do you envision that would work so that they do not conflict?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/WelcomeScreen.kt line 204 at r2 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
So this is more future-proofing, but we will add other types of dialoges in this view in the future connected to billing.
How do you envision that would work so that they do not conflict?
I think later on when we introduce navigation in compose we should have them as navigational paths. Much like you navigate to a screen (or fragment in our case) we should navigate to a dialog.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/WelcomeScreen.kt line 204 at r2 (raw file):
Previously, Rawa (David Göransson) wrote…
I think later on when we introduce navigation in compose we should have them as navigational paths. Much like you navigate to a screen (or fragment in our case) we should navigate to a dialog.
Sounds good!
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
Rawa
force-pushed
the
add-device-name-to-create-account-flow-droid-93
branch
from
92733e0
to
77df1ad
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
Rawa
force-pushed
the
add-device-name-to-create-account-flow-droid-93
branch
from
77df1ad
to
e7bb2eb
Compare
Fix TitleCase
Rawa
force-pushed
the
add-device-name-to-create-account-flow-droid-93
branch
from
e7bb2eb
to
414929c
Compare
There was a problem hiding this comment.
Reviewed 20 of 20 files at r5, all commit messages.
Reviewable status:
This commit adds device name to the welcome screen and a InfoDialog to clarify it.
This change is